lkml.org 
[lkml]   [2008]   [May]   [2]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH 5/7] PPS: serial clients support.
    On Fri, May 02, 2008 at 01:56:18PM +0100, Alan Cox wrote:
    > > So I should rewrite the uart_handle_dcd_change() as follow?
    > >
    > > static inline void
    > > uart_handle_dcd_change(struct uart_port *port, unsigned int status)
    > > {
    > > struct uart_info *info = port->info;
    > > struct tty_struct *tty = info->tty;
    > > struct tty_ldisc *ld;
    > >
    > > ld = tty_ldisc_ref(tty);
    > > if (ld != NULL) {
    > > if (ld->dcd_change)
    > > (ld->dcd_change)(tty, port, status);
    > > tty_ldisc_deref(ld);
    > > }
    > >
    > > port->icount.dcd++;
    > >
    > > #ifdef CONFIG_HARD_PPS
    > > if ((port->flags & UPF_HARDPPS_CD) && status)
    > > hardpps();
    > > #endif
    >
    > The ifdef bit can go - it will be in your dcd_change callback ..

    The "#ifdef CONFIG_HARD_PPS" is currently into kernel code, is *not*
    my modification at all. In fact you can find the flag UPF_HARDPPS_CD
    defined into include/linux/serial_core.h. It's a part of a very old
    PPS implemention (never merged into mainline) and it was used to
    enable the PPS layer for serial ports. That's why I didn't define an
    ldisc but implemented my PPS version using it. :)

    Ciao,

    Rodolfo

    --

    GNU/Linux Solutions e-mail: giometti@enneenne.com
    Linux Device Driver giometti@linux.it
    Embedded Systems phone: +39 349 2432127
    UNIX programming skype: rodolfo.giometti


    \
     
     \ /
      Last update: 2008-05-02 23:13    [W:0.024 / U:63.040 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site