Messages in this thread | | | From | Balaji Rao <> | Subject | Re: [RFC][-mm] Simple stats for cpu resource controller v3 | Date | Sat, 3 May 2008 01:10:28 +0530 |
| |
On Friday 02 May 2008 02:30:26 am Andrew Morton wrote: <snip>
Hi Andrew,
Thank you for the review. > > Did you consider using include/linux/percpu_counter.h? > > If so, what was wrong with it? > > Because it would be much better to fix per-cpu counters than to invent new > stuff. No, I hadn't consider using the percpu_counters infrastructure. But today when I tried using it, I got an early exception.I guess its because I tried calling percpu_counter_init from within sched_init, which I perhaps shouldn't do, because percpu_counter_init expects cpu hotplug code to be initialized by then. Right ? Correct me if I'm wrong.
How about we start collecting statistics at a later stage i.e, after percpu_counter becomes usable ?
-- Warm Regards,
Balaji Rao Dept. of Mechanical Engineering NITK
| |