Messages in this thread | | | Date | Fri, 2 May 2008 16:36:37 +0200 (CEST) | From | Thomas Gleixner <> | Subject | Re: [PATCH] clocksource: Fix permissions for available_clocksource |
| |
On Fri, 2 May 2008, Heiko Carstens wrote: > From: Heiko Carstens <heiko.carstens@de.ibm.com> > > File permissions for > /sys/devices/system/clocksource/clocksource0/available_clocksource > are 600 which allows write access. But this is in fact a read only > file. So change permissions to 400.
Indeed. The question is whether we should make this 444. There is no harm, when users can read the info. Same applies for the current_clocksource entry, making it 644 should be fine.
Thanks, tglx
> Cc: John Stultz <johnstul@us.ibm.com> > Cc: Thomas Gleixner <tglx@linutronix.de> > Signed-off-by: Heiko Carstens <heiko.carstens@de.ibm.com> > --- > kernel/time/clocksource.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > Index: linux-2.6/kernel/time/clocksource.c > =================================================================== > --- linux-2.6.orig/kernel/time/clocksource.c > +++ linux-2.6/kernel/time/clocksource.c > @@ -474,7 +474,7 @@ sysfs_show_available_clocksources(struct > static SYSDEV_ATTR(current_clocksource, 0600, sysfs_show_current_clocksources, > sysfs_override_clocksource); > > -static SYSDEV_ATTR(available_clocksource, 0600, > +static SYSDEV_ATTR(available_clocksource, 0400, > sysfs_show_available_clocksources, NULL); > > static struct sysdev_class clocksource_sysclass = { >
| |