Messages in this thread | | | Date | Fri, 2 May 2008 07:15:32 -0700 | From | "Jeff Schroeder" <> | Subject | Re: Btrfs v0.14 Released |
| |
On Fri, May 2, 2008 at 5:52 AM, Chris Mason <chris.mason@oracle.com> wrote: > On Friday 02 May 2008, Jan Engelhardt wrote: > > On Thursday 2008-05-01 22:10, Jeff Mahoney wrote: > > >>>> Couldn't you #ifdef based on CONFIG_SECURITY_APPARMOR ? This ought to > > >>>> work for Hardy. However the next development kernel (Intrepid) does > > >>>> not have the APPARMOR patches, so just knowing that its an UBUNTU > > >>>> kernel is not specific enough. > > >>> > > >>> I've been assuming the apparmor patches change remove_suid even when > > >>> they are not enabled in the config. > > >> > > >> Lets get Kees involved. He developed the patch set for Hardy. I would > > >> hope that if CONFIG_SECURITY_APPARMOR=n then the source would default to > > >> its normal state. > > > > > >remove_suid() isn't the only change AppArmor makes to the VFS interface. > > >It's pretty invasive and requires that dentries are passed with a > > >companion vfsmount in most cases. Putting #ifdefs around all that code > > >would make the problem worse, not better. > > > > An alternative approach, and IMHO better suited, is to: > > > > make -C ${kdir} all I_HAZ_AN_APPARMOR=1 > > This is better than the current situation (oops without any clues), but I'd > prefer that people not have to know what apparmor is or if they have it. > (This isn't a knock on apparmor, I'd just rather take care of it > automagically).
Chris,
Make is not my forte, but here is a working test to see if apparmor exists in Ubuntu 8.04. Maybe have make apply a patch to the btrfs source if this test succeeds? Does this work in SUSE?
http://www.digitalprognosis.com/opensource/patches/btrfs/lame_apparmor_test_for_btrfs.patch
The symlink from /lib/modules/`uname -r`/build -> /path/to/kernel/headers/ doesn't exist on CentOS 5. Even though it is a hack, is this or something like it usable? Or is this the completely wrong direction?
-- Jeff Schroeder
Don't drink and derive, alcohol and analysis don't mix. http://www.digitalprognosis.com
| |