Messages in this thread | | | Subject | Re: Horrendous Audio Stutter - current git | From | Peter Zijlstra <> | Date | Fri, 02 May 2008 13:51:03 +0200 |
| |
On Fri, 2008-05-02 at 13:45 +0200, Frans Pop wrote: > On Friday 02 May 2008, Peter Zijlstra wrote: > > On Fri, 2008-05-02 at 13:37 +0200, Frans Pop wrote: > > > On Friday 02 May 2008, Peter Zijlstra wrote: > > > > > Ok, that's _WAY_ too big, something went seriously wrong. Thanks! > > > > > > > > In fact, that is exactly 1024 time too large. > > > > > > > > How does this work for you: > > > > > > Changes nothing. Values of bonus_max are unchanged and still skips. > > > > Humm, I saw some bonus_max spikes on my laptop which were fixed by that > > patchlet, ah well, the hunt goes on. > > Oh! Hang on. I just checked and saw that I made the change in > dequeue_entity() instead of enqueue_entity(). Let me try again. > > For code symmetry I guess both should probably be changed?
Symetry would actually make it something like:
enqueue() A B C
dequeu() C B A
But I just quickly checked the code and I can't see any ill effect of mis-placing that code in dequeue() too.
| |