lkml.org 
[lkml]   [2008]   [May]   [2]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
SubjectRe: [PATCH] virtio_net: free transmit skbs in a timer
Date
On Thursday 01 May 2008 00:31:46 Mark McLoughlin wrote:
> virtio_net currently only frees old transmit skbs just
> before queueing new ones. If the queue is full, it then
> enables interrupts and waits for notification that more
> work has been performed.

Hi Mark,

This patch is fine, but it's better to do it from skb_xmit_done(). Of
course, this is usually called from an interrupt handler, so it's not
entirely trivial: we can't free the skbs there.

A softirq is probably the answer here, but AFAICT that's old fashioned.
Not sure what the right way of doing this is now...

Rusty.


\
 
 \ /
  Last update: 2008-05-02 12:59    [W:0.089 / U:0.392 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site