Messages in this thread | | | From | Rusty Russell <> | Subject | Re: [PATCH] virtio_net: free transmit skbs in a timer | Date | Fri, 2 May 2008 20:55:25 +1000 |
| |
On Thursday 01 May 2008 00:31:46 Mark McLoughlin wrote: > virtio_net currently only frees old transmit skbs just > before queueing new ones. If the queue is full, it then > enables interrupts and waits for notification that more > work has been performed.
Hi Mark,
This patch is fine, but it's better to do it from skb_xmit_done(). Of course, this is usually called from an interrupt handler, so it's not entirely trivial: we can't free the skbs there.
A softirq is probably the answer here, but AFAICT that's old fashioned. Not sure what the right way of doing this is now...
Rusty.
| |