lkml.org 
[lkml]   [2008]   [May]   [2]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] v4l/dvb: Add linux/version.h include as KERNEL_VERSION macro is used.
On Thu, 1 May 2008, Arjan van de Ven wrote:

> On Thu, 1 May 2008 20:05:41 +0200
> Andres Freund <andres@anarazel.de> wrote:
>
>> Whitout this build fails with unknown macro on
>> e4c576b911e364737b1bf4f5bfdab1c440713f26
>>
>> Hopefully I did everything correct, as this is my first usage of git
>> beside checking out. Also its my first patch on lk....
>>
>> Is an Signed-off-by already appropriate with such an trivial change?
>>
>
> Hi,
>
> maybe the real fix is to remove the use of KERNEL_VERSION in this code??

This is one of the rare cases where the usage of KERNEL_VERSION is valid.
This is the code there:

#include <linux/version.h> /* for KERNEL_VERSION MACRO */
#define RADIO_VERSION KERNEL_VERSION(0,7,7)
This macro is required by V4L API to indicate the module version.

One possible solution would be to fork KERNEL_VERSION into something like
V4L_VERSION, and replace it on drivers/media/video/* and
drivers/media/radio/*.
Yet, I'm not sure if it would be nice to have two macros with the same
code.

--
Cheers,
Mauro Carvalho Chehab
http://linuxtv.org
mchehab@infradead.org


\
 
 \ /
  Last update: 2008-05-02 12:17    [from the cache]
©2003-2011 Jasper Spaans