lkml.org 
[lkml]   [2008]   [May]   [19]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
SubjectRe: [patch v2] LMB: Add basic spin locking to lmb
From
From: Geoff Levand <geoffrey.levand@am.sony.com>
Date: Mon, 19 May 2008 17:55:45 -0700

> Add a spinlock to struct lmb to enforce concurrency in
> lmb_add(), lmb_remove(), lmb_analyze(), lmb_find(), and
> lmb_dump_all().
>
> This locking is needed for SMP systems that access the lmb structure
> during hot memory add and remove operations after secondary cpus
> have been started.
>
> Signed-off-by: Geoff Levand <geoffrey.levand@am.sony.com>
> ---
>
> v2: o Add locking to lmb_find().

I'm not against this patch, but I'm pretty sure it's not
necessary. Isn't memory hotplug already synchronized at
a higher level?

If not, it should be.


\
 
 \ /
  Last update: 2008-05-20 04:25    [W:0.045 / U:0.088 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site