lkml.org 
[lkml]   [2008]   [May]   [19]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] [1/11] Remove BKL from remote_llseek
On Mon, May 19, 2008 at 02:31:10PM +0200, Andi Kleen wrote:
>
> - Replace remote_llseek with remote_llseek_unlocked (to force compilation
> failures in all users)
> - Change all users to either use remote_llseek directly or take the
> BKL around. I changed the file systems who don't use the BKL
> for anything (CIFS, GFS) to call it directly. NCPFS and SMBFS and NFS
> take the BKL, but explicitely in their own source now.
>
> I moved them all over in a single patch to avoid unbisectable sections.

Good idea, but it could be done a little bit nicer still.

Your new remote_llseek_unlocked is the same as generic_file_llseek
except for the fact that it doesn't take i_mutex. So I'd rather
call it generic_file_llseek_nolock and make generic_file_llseek call
it. While you're at it you could also add some kerneldoc documents
describing them.



\
 
 \ /
  Last update: 2008-05-19 16:05    [W:0.123 / U:0.200 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site