Messages in this thread Patch in this message | | | Date | Sun, 18 May 2008 18:26:11 +0400 | From | Cyrill Gorcunov <> | Subject | [PATCH] eCryptFS: fix missed mutex_unlock |
| |
---
Ingo, could you please apply it and test? Actually I really doubt if it help with the locking problem you pointed. There are two procedures in miscrev.c - ecryptfs_miscdev_poll() and ecryptfs_miscdev_read() which takes/releases mutexes in a bit strange way... investigating, but this patch is needed anyway.
Index: linux-2.6.git/fs/ecryptfs/crypto.c =================================================================== --- linux-2.6.git.orig/fs/ecryptfs/crypto.c 2008-05-18 16:44:20.000000000 +0400 +++ linux-2.6.git/fs/ecryptfs/crypto.c 2008-05-18 17:56:12.000000000 +0400 @@ -1903,6 +1903,7 @@ int ecryptfs_get_tfm_and_mutex_for_ciphe if (rc) { printk(KERN_ERR "Error adding new key_tfm to list; " "rc = [%d]\n", rc); + mutex_unlock(&key_tfm_list_mutex); goto out; } }
| |