lkml.org 
[lkml]   [2008]   [May]   [18]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [RFC] make wext wireless bits optional and deprecate them
From
Date
On Sat, 2008-05-17 at 15:54 +0200, Johannes Berg wrote:
> On Sat, 2008-05-17 at 15:45 +0200, Marcel Holtmann wrote:
> > Hi Johannes,
> >
> > > The /sys/class/net/*/wireless/ direcory is, as far as I know, not
> > > used by anyone. Additionally, the same data is available via wext
> > > ioctls. Hence the sysfs files are pretty much useless. This patch
> > > makes them optional and schedules them for removal.
> >
> > it is used by HAL to classify WiFi network cards as net.80211 instead
> > of net.80203 and so we do have an actual user. However HAL only tests
> > for the existence of the directory wireless/.
>
> Oh, ok, I didn't know that, thanks.
>
> > Please fix HAL first before submitting such a patch.
>
> Sure, I'll take a look at that.

Instead of testing for wireless/, best thing would probably be to call
SIOCGIWRANGE on the device and if it returns EOPNOTSUP then it's not
wireless. Some drivers may have to load firmware to figure out
supported rates and encryption capabilities, but to be honest, NM does
this to detect wireless devices and I haven't run into any issues in 4
years using it. If there are issues with drivers, then we need to fix
the driver too.

dan



\
 
 \ /
  Last update: 2008-05-18 15:43    [W:0.181 / U:0.064 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site