Messages in this thread | | | Date | Tue, 13 May 2008 21:44:27 -0700 | From | "H. Peter Anvin" <> | Subject | Re: [PATCH 2/3] x86: janitor work in bugs.c |
| |
Joe Perches wrote: > On Tue, 2008-05-13 at 23:09 +0200, Andi Kleen wrote: >> We had a discussion recently that wrapping printk format strings >> is a bad idea. Don't do it please. > > I don't know that there was a resolution either. > http://lkml.org/lkml/2008/2/22/143 > > If there was one, there's a lot of possible changes. > > $ grep -rP --include=*.[ch] "printk.*\"\s*$\s*\"" * | wc -l > 13276 > > divide by 2, there are more than 6K split source line printks >
Perhaps a better idea would be to write a script to grep for strings.
-hpa
| |