Messages in this thread | | | Date | Wed, 14 May 2008 18:26:37 -0700 (PDT) | Subject | Re: [PATCH 2/3] sysfs: remove error messages for -EEXIST case | From | David Miller <> |
| |
From: Stephen Hemminger <shemminger@vyatta.com> Date: Wed, 14 May 2008 18:16:03 -0700
> It is possible that the entry in sysfs already exists, one case of this is > when a network device is renamed to bonding_masters. Anyway, in this case > the proper error path is for device_rename to return an error code, not to > generate bogus backtrace and errors. > > Also, to avoid possible races, the create link should be done before the > remove link. This makes a device rename atomic operation like other renames. > > Signed-off-by: Stephen Hemminger <shemminger@vyatta.com>
I definitely agree with this change.
We have several cases where device names are user configurable, yet the devices live in a directory which also has subdirectories created by other subsystems.
It's pointless to require the top-level guy to look for any purge out any subdirectory cases, that's none of it's business.
I realize the backtrace is useful for finding bugs, but in this case it's definitely not appropriate.
| |