lkml.org 
[lkml]   [2008]   [May]   [14]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH] OSS trident: switch from ->write_proc
    Thanks Alexey, some comments below. This patch is a step in the right
    direction but I'm afraid it's currently broken.

    On Wed, May 14, 2008 at 01:05:44AM +0400, Alexey Dobriyan wrote:

    > @@ -4441,11 +4446,8 @@ trident_probe(struct pci_dev *pci_dev, const struct pci_device_id *pci_id)
    > /* ALi SPDIF OUT function */
    > if (card->revision == ALI_5451_V02) {
    > ali_setup_spdif_out(card, ALI_PCM_TO_SPDIF_OUT);
    > - res = create_proc_entry("ALi5451", 0, NULL);
    > - if (res) {
    > - res->write_proc = ali_write_proc;
    > - res->data = card;
    > - }
    > + proc_create_data("ALi5451", 0, NULL,
    > + &ali_proc_fops, card);
    > }
    >
    > /* Add H/W Volume Control By Matt Wu Jul. 06, 2001 */

    This is not enough--we need to also remove the proc_entry if
    trident_probe() fails (see label `out_proc_fs'), which will require
    checking if proc_create_data() succeeded. Please send an updated patch
    or let me know and I'll take care of it.

    Also, I no longer have working trident hardware---if someone else does
    and can test this, please let me know. Otherwise we can should
    probably go ahead and remove this old OSS driver.

    Cheers,
    Muli


    \
     
     \ /
      Last update: 2008-05-14 09:01    [W:0.025 / U:33.856 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site