Messages in this thread | | | Date | Wed, 14 May 2008 22:05:59 +0200 | From | Frederik Deweerdt <> | Subject | Re: [announce] "kill the Big Kernel Lock (BKL)" tree |
| |
Hi Ingo, On Wed, May 14, 2008 at 09:41:22PM +0200, Ingo Molnar wrote: > Subject: remove bkl: reiserfs fix > From: Ingo Molnar <mingo@elte.hu> > Date: Wed May 14 16:26:36 CEST 2008 > > avoid j_commit_lock deadlock. Since the down() can block it is > safe to drop the BKL here. > > Signed-off-by: Ingo Molnar <mingo@elte.hu> > --- > fs/reiserfs/journal.c | 2 ++ > fs/super.c | 2 ++ > 2 files changed, 4 insertions(+) > > Index: linux/fs/reiserfs/journal.c > =================================================================== > --- linux.orig/fs/reiserfs/journal.c > +++ linux/fs/reiserfs/journal.c > @@ -1044,8 +1044,10 @@ static int flush_commit_list(struct supe > } > } > > +// unlock_kernel(); ^^^^ > /* make sure nobody is trying to flush this one at the same time */ > down(&jl->j_commit_lock); > +// lock_kernel(); ^^^^ > if (!journal_list_still_alive(s, trans_id)) { > up(&jl->j_commit_lock); > goto put_jl; Must be a typo?
Regards, Frederik
| |