lkml.org 
[lkml]   [2008]   [May]   [13]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRE: [PATCH 1/1] [INPUT/KEYPAD] gpio keypad: Replace current blackfin specific pfbutton driver with kernel generic gpio key driver
Date
From


>-----Original Message-----
>From: Mike Frysinger [mailto:vapier.adi@gmail.com]
>Sent: Montag, 12. Mai 2008 19:00
>To: David Brownell
>Cc: Bryan Wu; pHilipp Zabel; dbrownell@users.sourceforge.net;
>dmitry.torokhov@gmail.com; linux-kernel@vger.kernel.org; Michael
Hennerich
>Subject: Re: [PATCH 1/1] [INPUT/KEYPAD] gpio keypad: Replace current
>blackfin specific pfbutton driver with kernel generic gpio key driver
>
>On Mon, May 12, 2008 at 12:54 PM, David Brownell wrote:
>> On Monday 12 May 2008, Bryan Wu wrote:
>> > Right. I mean the generic GPIO layer in Blackfin port, not the
common
>code.
>> >
>> > And on the other hand, maybe there are also other hardware which
has
>similar
>> > issue as Blackfin. So the common GPIO layer can take care of this,
how
>> > do you think, David?
>>
>> No; it's a Blackfin-specific design flaw, one that I've not seen
>> in any other chip's GPIO support. So it should stay in the Blackfin
>> support code. (Possibly even specialized for the specific chips
>> which have that flaw/erratum.)
>
>afaik, it was a design flaw, not an erratum ... newer parts have the
>situation rectified. but Michael would be able to comment more
>authoritatively on the topic. we already have the logic to only make
>the swap for parts that need it.
>-mike

I agree with all. This hack patch shouldn't be discussed here. I must
have overseen this while we discussed what to send upstream.

Please disregard.

-Michael



\
 
 \ /
  Last update: 2008-05-13 09:59    [W:0.277 / U:0.044 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site