Messages in this thread | | | Date | Wed, 14 May 2008 10:50:31 +0800 | From | "Bryan Wu" <> | Subject | Re: [PATCH 1/1] [MTD/MAPS] Blackfin Async Flash Maps: Handle the case where flash memory and ethernet mac/phy are mapped onto the same async bank |
| |
On Wed, May 14, 2008 at 3:16 AM, Jörn Engel <joern@logfs.org> wrote: > > On Tue, 13 May 2008 13:42:04 -0400, Mike Frysinger wrote: > > On Tue, May 13, 2008 at 11:34 AM, Jörn Engel <joern@logfs.org> wrote: > > > On Tue, 13 May 2008 12:38:45 +0800, Bryan Wu wrote: > > > > +#define pr_devinit(fmt, args...) ({ static const __devinitdata char __fmt[] = fmt; printk(__fmt, ## args); }) > > > > > > That bit is obvious. But why do you use pr_devinit() instead of > > > printk()? What does it gain you? > > > > why do we have __init and __devinit in the first place ? > > Ah. Now I finally understand what this code does. > > Might be worth moving it to include/linux/kernel.h, along with > pr_init(). And watch an avalanche of janitor patches use these new > toys. :) >
Yes, I agree. Mike, could you consider providing a patch to add pr_devinit to common code? IMO, your weapon can be shared by others.
Thanks -Bryan -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |