lkml.org 
[lkml]   [2008]   [May]   [13]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [RFC/PATCH 3/8]: CGroup Files: Move the release_agent file to use typed handlers
On Tue, May 13, 2008 at 1:08 PM, Andrew Morton
<akpm@linux-foundation.org> wrote:
> On Mon, 12 May 2008 23:37:10 -0700
> menage@google.com wrote:
>
> > + agentbuf = kmalloc(PATH_MAX, GFP_KERNEL);
> > + if (!agentbuf)
> > + goto continue_free;
> > + strcpy(agentbuf, cgrp->root->release_agent_path);
>
> Did we need to allocate all that memory, or would kstrdup() suffice?
>

kstrdup() would be fine. Fixed.

Paul


\
 
 \ /
  Last update: 2008-05-13 23:37    [from the cache]
©2003-2011 Jasper Spaans