lkml.org 
[lkml]   [2008]   [May]   [13]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
Subject[PATCH 0/2] /fs/partition/check.c : fix return value warning (V2)
Date
On Tue, May 13, 2008 at 12:27 AM, Andrew Morton <akpm@linux-foundation.org> wrote:
> On Sat, 10 May 2008 13:40:53 +0200
> Abdel Benamrouche <draconux@gmail.com> wrote:
>
> > fs/partitions/check.c:381: warning: ignoring return value of ___device_add___,
> > declared with attribute warn_unused_result
> >
> > Signed-off-by: Abdel Benamrouche <draconux@gmail.com>
> > ---
> > :100644 100644 6149e4b... 7a87fad... M fs/partitions/check.c
> > fs/partitions/check.c | 8 +++++++-
> > 1 files changed, 7 insertions(+), 1 deletions(-)
> >
> > diff --git a/fs/partitions/check.c b/fs/partitions/check.c
> > index 6149e4b..7a87fad 100644
> > --- a/fs/partitions/check.c
> > +++ b/fs/partitions/check.c
> > @@ -378,7 +378,13 @@ void add_partition(struct gendisk *disk, int part, sector_t start, sector_t len,
> >
> > /* delay uevent until 'holders' subdir is created */
> > p->dev.uevent_suppress = 1;
> > - device_add(&p->dev);
> > + if (device_add(&p->dev)) {
> > + put_device(&p->dev);
> > + free_part_stats(p);
> > + kfree(p);
> > + return;
> > + }
> > +
> > partition_sysfs_add_subdir(p);
> > p->dev.uevent_suppress = 0;
> > if (flags & ADDPART_FLAG_WHOLEDISK)
>
> We should go further than this. add_partition() just drops the error
> on the floor. It should be propagated back to callers, and callers
> should be modified to handle it appropriately.
>
> Presumably we should also handle a device_create_file() failure as well
> - that is presently being silently ignored.
>
>

done.
I make 2 patch so that it will be easier to read.





\
 
 \ /
  Last update: 2008-05-13 22:05    [W:0.034 / U:0.020 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site