Messages in this thread | | | Date | Mon, 12 May 2008 16:20:17 -0600 | From | "Grant Likely" <> | Subject | Re: [PATCH/RFC] spi: Change modalias from a pointer to a character array |
| |
On Mon, May 12, 2008 at 4:18 PM, Andrew Morton <akpm@linux-foundation.org> wrote: > > On Fri, 09 May 2008 11:32:28 -0600 > Grant Likely <grant.likely@secretlab.ca> wrote: > > > From: Grant Likely <grant.likely@secretlab.ca> > > > > Currently, 'modalias' in the spi_device structure is a 'const char *'. > > The spi_new_device() function fills in the modalias value from a passed > > in spi_board_info data block. Since it is a pointer copy, the new > > spi_device remains dependent on the spi_board_info structure after the > > new spi_device is registered (no other fields in spi_device directly > > depend on the spi_board_info structure; all of the other data is copied). > > <snip> > > I'm not really able to work out if this is a needed-in-2.6.26 thing. I > assumed "not".
That's correct. I'm also not even 100% sure that this is the best approach. I'm waiting/hoping for feedback from David.
Cheers, g.
-- Grant Likely, B.Sc., P.Eng. Secret Lab Technologies Ltd.
| |