lkml.org 
[lkml]   [2008]   [May]   [11]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH 08/56] microblaze_v2: Interrupt handling, timer support, supported function
    Michal,

    On Sun, 11 May 2008, Michal Simek wrote:
    > >
    > > Please split this modification code out into a separate function. The
    > > same code is used below.
    >
    > Add Macro.

    Please use a (inline) function whenever possible. Macros are harder to
    read and not type safe.

    > > Can you please move a new architecture to clockevents / clocksource
    > > right from the beginning ? No need to invent another incompatible set
    > > of time(r) related functions.
    >
    > I move whole code to GENERIC_TIME. Did you meant any others changes?

    GENERIC_TIME and GENERIC_CLOCKEVENTS. You get high resolution timers
    and dynamic ticks for free when your timer hardware allows it.

    > >> +#define NO_IRQ (-1)
    > >> +
    > >> +static inline int irq_canonicalize(int irq)
    > >> +{
    > >> + return (irq);
    > >> +}
    > >
    > > Why is this needed ? Any users ?
    >
    > is used in serial_core.c
    > 684 new_serial.irq = irq_canonicalize(new_serial.irq);

    Doh, forgot about that one.

    Thanks,
    tglx


    \
     
     \ /
      Last update: 2008-05-11 16:41    [W:0.020 / U:64.148 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site