Messages in this thread | | | Date | Sun, 11 May 2008 22:29:05 +0400 | From | Cyrill Gorcunov <> | Subject | Re: 2.6.26-rc1 on x86: ld: warning: dot moved backwards before `.text' |
| |
[H. Peter Anvin - Sun, May 11, 2008 at 11:25:54AM -0700] > Cyrill Gorcunov wrote: >> Hi Peter, >> actually I only doubt about exactly position of this headers - I mean >> meguess it better should be _before_ "_end" not after. Since the others >> script uses (acpi/wakeup_rm.S): >> wakeup_code_start: >> .incbin "arch/x86/kernel/acpi/realmode/wakeup.bin" >> wakeup_code_end: >> and kernel uses these wakeup_code_* marks to save/restore memory I think >> it should be like >> . = HEADER_OFFSET; >> .header : { >> ... >> } >> . = ALIGN(16); >> _end = .; >> /DISCARD/ ... > > Yes, I believe that's correct. > > -hpa >
Thanks for review, Peter, I'll cook a patch and wait for Pavel's opinion ;-)
- Cyrill -
| |