Messages in this thread Patch in this message | | | Date | Thu, 1 May 2008 18:52:05 -0400 (EDT) | From | Steven Rostedt <> | Subject | [PATCH] fix irq flags for iuu_phoenix.c |
| |
The file drivers/usb/serial/iuu_phoenix.c uses "int" for flags. This can cause hard to find bugs on some architectures. This patch converts the flags to use "long" instead.
This bug was discovered by doing an allyesconfig make on the -rt kernel where checks are done to ensure all flags are of size sizeof(long).
Signed-off-by: Steven Rostedt <srostedt@redhat.com> --- drivers/usb/serial/iuu_phoenix.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-)
Index: linux-compile.git/drivers/usb/serial/iuu_phoenix.c =================================================================== --- linux-compile.git.orig/drivers/usb/serial/iuu_phoenix.c 2008-05-01 16:58:50.000000000 -0400 +++ linux-compile.git/drivers/usb/serial/iuu_phoenix.c 2008-05-01 18:45:03.000000000 -0400 @@ -643,7 +643,7 @@ static void read_buf_callback(struct urb static int iuu_bulk_write(struct usb_serial_port *port) { struct iuu_private *priv = usb_get_serial_port_data(port); - unsigned int flags; + unsigned long flags; int result; int i; char *buf_ptr = port->write_urb->transfer_buffer; @@ -694,7 +694,7 @@ static void iuu_uart_read_callback(struc { struct usb_serial_port *port = urb->context; struct iuu_private *priv = usb_get_serial_port_data(port); - unsigned int flags; + unsigned long flags; int status; int error = 0; int len = 0; @@ -759,7 +759,7 @@ static int iuu_uart_write(struct usb_ser int count) { struct iuu_private *priv = usb_get_serial_port_data(port); - unsigned int flags; + unsigned long flags; dbg("%s - enter", __func__);
if (count > 256)
| |