Messages in this thread | | | Date | Thu, 1 May 2008 17:25:48 -0400 (EDT) | From | Steven Rostedt <> | Subject | Re: [PATCH] fix flags length in net 9p |
| |
[ I added Ingo since I think he created the check ]
On Thu, 1 May 2008, Andrew Morton wrote:
> On Thu, 1 May 2008 17:08:05 -0400 (EDT) > Steven Rostedt <rostedt@goodmis.org> wrote: > > > Some files in the net/9p directory uses "int" for flags. This can > > cause hard to find bugs on some architectures. This patch converts the > > flags to use "long" instead. > > gargh. > > > This bug was discovered by doing an allyesconfig make on the -rt kernel > > where checks are done to ensure all flags are of size sizeof(long). > > I was about to suggest that we do something like that... > > I wonder how messy it is. I long ago lost the ability to follow the > convolutions in include/linux/spinlock*.h :( gotta patch?
It's not messy at all, it's actually quite elegant. I can pull it out of the -rt tree, or perhaps Ingo can quickly whip one up as well.
Ingo, you want me to pull it out?
-- Steve
| |