lkml.org 
[lkml]   [2008]   [May]   [1]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH] clocksource: shift helper
    On Thu, May 01, 2008 at 12:48:25PM -0700, Daniel Walker wrote:

    > > If we expect this to have more than one callsite then it would be best to
    > > uninline it.
    > >
    > > Unless we always expect it to be called from __init code, in which case
    > > it's best to inline it ;)
    >
    > I expect it would always get called from __init flagged functions. The
    > clocksource can't get registed/used with out the shift and mult values.
    >
    > If we did uninline this one, we would have to do the other helpers too.
    > I imagine the use case is the same for all of them ..

    I could imagine this being called for hotpluggable CPUs or nodes, so rather
    __cpuinit than __init.

    Ralf


    \
     
     \ /
      Last update: 2008-05-01 23:11    [W:3.613 / U:0.056 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site