lkml.org 
[lkml]   [2008]   [May]   [1]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    Date
    From
    Subject[PATCH] x86 mmiotrace: page level is unsigned
    From 8261c3eeead01739d18875797816637621d17c2d Mon Sep 17 00:00:00 2001
    From: Pekka Paalanen <pq@iki.fi>
    Date: Thu, 1 May 2008 16:15:11 +0300
    Subject: [PATCH] x86 mmiotrace: page level is unsigned

    Fixes some sparse warnings.

    Signed-off-by: Pekka Paalanen <pq@iki.fi>
    ---

    There are three other sparse warnings, too, but two are false
    positives and one is a code style issue. I do not know how to annotate
    those away, or if it is even possible, so I will probably write a
    proper question some time after the merge window closes about how to
    deal with those.

    arch/x86/mm/kmmio.c | 13 +++++++------
    arch/x86/mm/mmio-mod.c | 2 +-
    2 files changed, 8 insertions(+), 7 deletions(-)

    diff --git a/arch/x86/mm/kmmio.c b/arch/x86/mm/kmmio.c
    index c12be07..93d8203 100644
    --- a/arch/x86/mm/kmmio.c
    +++ b/arch/x86/mm/kmmio.c
    @@ -105,11 +105,12 @@ static struct kmmio_fault_page *get_kmmio_fault_page(unsigned long page)
    return NULL;
    }

    -static void set_page_present(unsigned long addr, bool present, int *pglevel)
    +static void set_page_present(unsigned long addr, bool present,
    + unsigned int *pglevel)
    {
    pteval_t pteval;
    pmdval_t pmdval;
    - int level;
    + unsigned int level;
    pmd_t *pmd;
    pte_t *pte = lookup_address(addr, &level);

    @@ -146,15 +147,15 @@ static void set_page_present(unsigned long addr, bool present, int *pglevel)
    }

    /** Mark the given page as not present. Access to it will trigger a fault. */
    -static void arm_kmmio_fault_page(unsigned long page, int *page_level)
    +static void arm_kmmio_fault_page(unsigned long page, unsigned int *pglevel)
    {
    - set_page_present(page & PAGE_MASK, false, page_level);
    + set_page_present(page & PAGE_MASK, false, pglevel);
    }

    /** Mark the given page as present. */
    -static void disarm_kmmio_fault_page(unsigned long page, int *page_level)
    +static void disarm_kmmio_fault_page(unsigned long page, unsigned int *pglevel)
    {
    - set_page_present(page & PAGE_MASK, true, page_level);
    + set_page_present(page & PAGE_MASK, true, pglevel);
    }

    /*
    diff --git a/arch/x86/mm/mmio-mod.c b/arch/x86/mm/mmio-mod.c
    index ed0e0e9..e7397e1 100644
    --- a/arch/x86/mm/mmio-mod.c
    +++ b/arch/x86/mm/mmio-mod.c
    @@ -137,7 +137,7 @@ static ssize_t write_marker(struct file *file, const char __user *buffer,

    static void print_pte(unsigned long address)
    {
    - int level;
    + unsigned int level;
    pte_t *pte = lookup_address(address, &level);

    if (!pte) {
    --
    1.5.3.7


    \
     
     \ /
      Last update: 2008-05-01 17:41    [W:0.023 / U:2.292 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site