Messages in this thread | | | Date | Wed, 9 Apr 2008 20:13:14 +0200 | From | Richard Zidlicky <> | Subject | Re: [PATCH 5/5] falconide/q40ide: add ->atapi_*put_bytes and ->ata_*put_data methods |
| |
On Wed, Apr 09, 2008 at 03:40:34AM +0200, Michael Schmitz wrote:
> > However, not only FS data is byteswapped, complete disk including partition > > table and everything else is. Will "rq->cmd_type == REQ_TYPE_FS" also catch > > all these cases? > > IIRC only identify data (and perhaps ATAPI data) need to be byteswapped > twice (or not at all), so REQ_TYPE_FS should catch all other cases.
my main worry is whether REQ_TYPE_FS is set even when using raw disk access, eg reading partition table or raw partitions.
The partition table initialisation is one of the reasons why using dmapper would be a major pain btw.
> (Good catch about ATAPI there, BTW - I never thought about that, and ISTR > that IDE CD-ROMs never worked in Linux. That would be the reason why..)
IDE CDROM works perfectly on the Q40?
Richard
| |