Messages in this thread | | | Date | Wed, 9 Apr 2008 19:51:23 +0200 | From | "Bert Wesarg" <> | Subject | Re: [PATCH 0/3] x86: add cpus_scnprintf function v3 |
| |
On Tue, Apr 8, 2008 at 8:43 PM, Mike Travis <travis@sgi.com> wrote: > * Cleanup usages of cpumask_scprintf in the following files and add > another interface to use cpulist_scnprintf where appropriate.
On Mon, Apr 7, 2008 at 8:22 PM, Mike Travis <travis@sgi.com> wrote: > Part of the change is readability, but also looking towards the future > of 16k/64k/??? # of cpus, the straight mask approach will overflow the > PAGE_SIZE buffer provided (though some pathological cases will overflow > the range method as well.) So we'll need some advancement in the format > of the printout.
Btw, I think you can now push for a deprecation of the 'old' mask attributes, with the justification you have given above. The other possibility is to change sysfs to provide bigger attribute buffers (CCed Greg for this).
Bert
| |