lkml.org 
[lkml]   [2008]   [Apr]   [8]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 4/4] pxafb: preliminary smart panel interface support
On Tue, 8 Apr 2008 12:07:27 +0800 "eric miao" <eric.y.miao@gmail.com> wrote:

> +static int pxafb_smart_thread(void *arg)
> +{
> + struct pxafb_info *fbi = (struct pxafb_info *) arg;

Please don't typecast when assigning a pointer to or from void*.

Reasons:

- It defeats typechecking: if someone later converts `arg' to a u8, they
won't even get a compiler warning.

- Improved code readability.



\
 
 \ /
  Last update: 2008-04-08 10:27    [W:0.040 / U:0.504 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site