lkml.org 
[lkml]   [2008]   [Apr]   [8]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    Date
    From
    Subject[RFC][PATCH 1/7]: Propagate error code from devpts_pty_new

    From: Sukadev Bhattiprolu <sukadev@us.ibm.com>
    Subject: [RFC][PATCH 1/7]: Propagate error code from devpts_pty_new

    Have ptmx_open() propagate any error code returned by devpts_pty_new()
    (which returns either 0 or -ENOMEM anyway).

    Signed-off-by: Sukadev Bhattiprolu <sukadev@us.ibm.com>
    ---
    drivers/char/tty_io.c | 4 ++--
    1 file changed, 2 insertions(+), 2 deletions(-)

    Index: 2.6.25-rc8-mm1/drivers/char/tty_io.c
    ===================================================================
    --- 2.6.25-rc8-mm1.orig/drivers/char/tty_io.c 2008-04-07 14:49:56.000000000 -0700
    +++ 2.6.25-rc8-mm1/drivers/char/tty_io.c 2008-04-08 09:12:55.000000000 -0700
    @@ -2835,8 +2835,8 @@ static int ptmx_open(struct inode *inode
    filp->private_data = tty;
    file_move(filp, &tty->tty_files);

    - retval = -ENOMEM;
    - if (devpts_pty_new(tty->link))
    + retval = devpts_pty_new(tty->link);
    + if (retval)
    goto out1;

    check_tty_count(tty, "tty_open");

    \
     
     \ /
      Last update: 2008-04-09 00:01    [W:0.044 / U:122.628 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site