lkml.org 
[lkml]   [2008]   [Apr]   [7]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH 0/4] x86: add cpus_scnprintf function v2
    On Mon, Apr 7, 2008 at 10:04 AM, Paul Jackson <pj@sgi.com> wrote:
    > I still have some concerns with this cpus_scnprintf patch.
    >
    > I've taken them up with Mike offline for initial consideration.
    >
    > If others have questions, concerns or enthusiasms for this patch,
    > Mike and I would be interested.
    As long as the only justification for this cpus_scnprintf is human
    readability, I have concerns too.

    Patch 2/4 itself is ok and 4/4 too. The only thing I miss is an export
    of NR_CPUS. So that you know in front of reading a kernel mask, what
    size your bitmap needs. (for example glibc cpu_set_t has only 1024
    bits but has an cpu_set_t with arbitrary size too).

    Bert


    \
     
     \ /
      Last update: 2008-04-07 16:11    [W:0.022 / U:3.452 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site