lkml.org 
[lkml]   [2008]   [Apr]   [7]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH 2/4] x86: modify show_shared_cpu_map in intel_cacheinfo v2
    On Sat, Apr 5, 2008 at 3:24 AM, Mike Travis <travis@sgi.com> wrote:
    > --- linux-2.6.x86.orig/arch/x86/kernel/cpu/intel_cacheinfo.c
    > +++ linux-2.6.x86/arch/x86/kernel/cpu/intel_cacheinfo.c
    > @@ -593,14 +593,17 @@ static ssize_t show_size(struct _cpuid4_
    >
    > static ssize_t show_shared_cpu_map(struct _cpuid4_info *this_leaf, char *buf)
    > {
    > + unsigned long end = ALIGN((unsigned long)buf, PAGE_SIZE);
    May I suggest this:

    ptrdiff_t len = PTR_ALIGN(buf + PAGE_SIZE - 1, PAGE_SIZE) - buf;

    > + if (len == 0)
    > + len = PAGE_SIZE;
    Than this is not necessary.

    > +
    > + if (len >= 2) {
    > + n = cpus_scnprintf(buf, len-2, this_leaf->shared_cpu_map);
    > + buf[n++] = '\n';
    > + buf[n] = '\0';
    > }
    > return n;
    > }
    Apart from my suggestion and the use of cpus_scnprintf I think this patch is ok.

    Bert

    PS: sorry for the long delay.


    \
     
     \ /
      Last update: 2008-04-07 16:01    [W:0.020 / U:296.364 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site