lkml.org 
[lkml]   [2008]   [Apr]   [4]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] i386: additional fix for making ioremap() accept 64-bit addresses

* Jan Beulich <jbeulich@novell.com> wrote:

> The recent change to __ioremap()'s first parameter's type didn't yield
> the intended effect as the first conditional inside the function would
> still have filtered out any addresses with bits [63:32] set. Correct
> last_addr's type and at once also add a check that the address range
> doesn't extend into space hardware cannot support even theoretically.

i fixed this in x86.git more than a week ago, see:

| Subject: x86: ioremap of 64-bit resource on 32-bit kernel fix
| From: Ingo Molnar <mingo@elte.hu>
| Date: Tue, 25 Mar 2008 08:31:17 +0100

but since 64-bit resources never worked on 32-bit and the initiator
regression causing this discussion turned out to be something else, i
delayed this fix as .26 material.

the PHYSICAL_MASK fix looks good as an additional check - could you
please resend it against x86.git/latest which has my fix already?

Ingo


\
 
 \ /
  Last update: 2008-04-04 15:03    [from the cache]
©2003-2011 Jasper Spaans