lkml.org 
[lkml]   [2008]   [Apr]   [30]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH 02/10] scsi: fix integer as NULL pointer warnings
From
Date
On Wed, 2008-04-30 at 15:34 -0700, Harvey Harrison wrote:
> On Wed, 2008-04-30 at 17:29 -0500, James Bottomley wrote:
> > On Wed, 2008-04-30 at 15:03 -0700, Harvey Harrison wrote:
> > > drivers/scsi/FlashPoint.c:906:9: warning: Using plain integer as NULL pointer
> > > drivers/scsi/FlashPoint.c:907:53: warning: Using plain integer as NULL pointer
> > > drivers/scsi/FlashPoint.c:922:1: warning: Using plain integer as NULL pointer
>
> > The flashpoint initialiser changes look wrong: {0} is a conventional
> > notation for zero initialise this structure. Sparse should probably be
> > taught to recognise that.
>
> Actually, looking closer, should this be initialized at all? Can we
> just remove the initialization here and let them end up in .bss?

Yes, but the conventional initialiser doesn't change that (as in zero
initialise a static and it ends up in bss anyway).

James




\
 
 \ /
  Last update: 2008-05-01 00:57    [W:0.060 / U:0.256 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site