Messages in this thread | | | Subject | Re: [PATCH 02/10] scsi: fix integer as NULL pointer warnings | From | James Bottomley <> | Date | Wed, 30 Apr 2008 17:54:38 -0500 |
| |
On Wed, 2008-04-30 at 15:34 -0700, Harvey Harrison wrote: > On Wed, 2008-04-30 at 17:29 -0500, James Bottomley wrote: > > On Wed, 2008-04-30 at 15:03 -0700, Harvey Harrison wrote: > > > drivers/scsi/FlashPoint.c:906:9: warning: Using plain integer as NULL pointer > > > drivers/scsi/FlashPoint.c:907:53: warning: Using plain integer as NULL pointer > > > drivers/scsi/FlashPoint.c:922:1: warning: Using plain integer as NULL pointer > > > The flashpoint initialiser changes look wrong: {0} is a conventional > > notation for zero initialise this structure. Sparse should probably be > > taught to recognise that. > > Actually, looking closer, should this be initialized at all? Can we > just remove the initialization here and let them end up in .bss?
Yes, but the conventional initialiser doesn't change that (as in zero initialise a static and it ends up in bss anyway).
James
| |