Messages in this thread Patch in this message | | | Subject | [PATCH 09/10] misc: fix returning void-valued expression warnings | From | Harvey Harrison <> | Date | Wed, 30 Apr 2008 15:03:44 -0700 |
| |
kernel/sched_fair.c:845:3: warning: returning void-valued expression kernel/sched.c:4343:3: warning: returning void-valued expression security/security.c:897:2: warning: returning void-valued expression security/security.c:1014:2: warning: returning void-valued expression security/security.c:1019:2: warning: returning void-valued expression sound/sound_core.c:410:2: warning: returning void-valued expression sound/sound_core.c:427:2: warning: returning void-valued expression
Signed-off-by: Harvey Harrison <harvey.harrison@gmail.com> --- Peter, I know you don't like this very much, but it would help reduce the trivial noise somewhat in a sparse build.
kernel/sched.c | 6 ++++-- kernel/sched_fair.c | 6 ++++-- security/security.c | 6 +++--- sound/sound_core.c | 4 ++-- 4 files changed, 13 insertions(+), 9 deletions(-)
diff --git a/kernel/sched.c b/kernel/sched.c index e2f7f5a..864daf8 100644 --- a/kernel/sched.c +++ b/kernel/sched.c @@ -4339,8 +4339,10 @@ void account_system_time(struct task_struct *p, int hardirq_offset, struct rq *rq = this_rq(); cputime64_t tmp; - if ((p->flags & PF_VCPU) && (irq_count() - hardirq_offset == 0)) - return account_guest_time(p, cputime); + if ((p->flags & PF_VCPU) && (irq_count() - hardirq_offset == 0)) { + account_guest_time(p, cputime); + return; + } p->stime = cputime_add(p->stime, cputime); diff --git a/kernel/sched_fair.c b/kernel/sched_fair.c index 89fa32b..0bd575e 100644 --- a/kernel/sched_fair.c +++ b/kernel/sched_fair.c @@ -841,8 +841,10 @@ entity_tick(struct cfs_rq *cfs_rq, struct sched_entity *curr, int queued) * queued ticks are scheduled to match the slice, so don't bother * validating it and just reschedule. */ - if (queued) - return resched_task(rq_of(cfs_rq)->curr); + if (queued) { + resched_task(rq_of(cfs_rq)->curr); + return; + } /* * don't let the period tick interfere with the hrtick preemption */ diff --git a/security/security.c b/security/security.c index 59838a9..8073a1a 100644 --- a/security/security.c +++ b/security/security.c @@ -894,7 +894,7 @@ EXPORT_SYMBOL(security_secctx_to_secid); void security_release_secctx(char *secdata, u32 seclen) { - return security_ops->release_secctx(secdata, seclen); + security_ops->release_secctx(secdata, seclen); } EXPORT_SYMBOL(security_release_secctx); @@ -1011,12 +1011,12 @@ int security_sk_alloc(struct sock *sk, int family, gfp_t priority) void security_sk_free(struct sock *sk) { - return security_ops->sk_free_security(sk); + security_ops->sk_free_security(sk); } void security_sk_clone(const struct sock *sk, struct sock *newsk) { - return security_ops->sk_clone_security(sk, newsk); + security_ops->sk_clone_security(sk, newsk); } void security_sk_classify_flow(struct sock *sk, struct flowi *fl) diff --git a/sound/sound_core.c b/sound/sound_core.c index 46daca1..b2538bf 100644 --- a/sound/sound_core.c +++ b/sound/sound_core.c @@ -407,7 +407,7 @@ EXPORT_SYMBOL(unregister_sound_mixer); void unregister_sound_midi(int unit) { - return sound_remove_unit(&chains[2], unit); + sound_remove_unit(&chains[2], unit); } EXPORT_SYMBOL(unregister_sound_midi); @@ -424,7 +424,7 @@ EXPORT_SYMBOL(unregister_sound_midi); void unregister_sound_dsp(int unit) { - return sound_remove_unit(&chains[3], unit); + sound_remove_unit(&chains[3], unit); }
-- 1.5.5.1.305.g7c84
| |