Messages in this thread Patch in this message | | | Date | Wed, 30 Apr 2008 16:30:30 -0400 | From | Andres Salomon <> | Subject | [PATCH 4/4] power_supply: bump EC version check that we refuse to run with in olpc_battery |
| |
Refuse to run with an EC < 0x44. We're playing it safe, and this is a pretty old EC version.
Also, add a comment about why we're checking the EC version.
Signed-off-by: Andres Salomon <dilinger@debian.org> --- drivers/power/olpc_battery.c | 7 ++++++- 1 files changed, 6 insertions(+), 1 deletions(-)
diff --git a/drivers/power/olpc_battery.c b/drivers/power/olpc_battery.c index cb45a67..086b146 100644 --- a/drivers/power/olpc_battery.c +++ b/drivers/power/olpc_battery.c @@ -398,7 +398,12 @@ static int __init olpc_bat_init(void) if (!olpc_platform_info.ecver) return -ENXIO; - if (olpc_platform_info.ecver < 0x43) { + + /* + * We've seen a number of EC protocol changes; this driver requires + * the latest EC protocol, supported by 0x44 and above. + */ + if (olpc_platform_info.ecver < 0x44) { printk(KERN_NOTICE "OLPC EC version 0x%02x too old for battery driver.\n", olpc_platform_info.ecver); return -ENXIO; } -- 1.5.5
| |