Messages in this thread | | | Subject | Re: [v4l-dvb-maintainer] [patch, -git] drivers/media build fix for modular builds | From | Mike Galbraith <> | Date | Wed, 30 Apr 2008 18:01:55 +0200 |
| |
On Wed, 2008-04-30 at 11:39 -0400, Michael Krufky wrote:
> > ...and about your previous fix: > > --- a/drivers/media/video/tuner-core.c~drivers-media-video-tuner-corec-tuner_probe-fix-error-check > +++ a/drivers/media/video/tuner-core.c > @@ -1181,7 +1181,7 @@ static int tuner_probe(struct i2c_client > case 0x60: > if (tuner_symbol_probe(tea5767_autodetection, > t->i2c->adapter, t->i2c->addr) > - != EINVAL) { > + != -EINVAL) { > t->type = TUNER_TEA5767; > t->mode_mask = T_RADIO; > t->mode = T_STANDBY; > > > I think we're better off testing for >= 0. Any < 0 should be > considered a failure.
I tried it anyway, still went boom.
-Mike
| |