lkml.org 
[lkml]   [2008]   [Apr]   [30]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    Date
    From
    Subject[PATCH] Fix for memory initialisation debugging framework
    On (29/04/08 14:26), akpm@linux-foundation.org didst pronounce:
    >
    > The patch titled
    > mm: add a basic debugging framework for memory initialisation
    > has been added to the -mm tree. Its filename is
    > mm-add-a-basic-debugging-framework-for-memory-initialisation.patch
    >

    This patch is a fix to
    mm-add-a-basic-debugging-framework-for-memory-initialisation.patch pointed out
    by an off-list reviewer. The intention of the code was to change the printk
    loglevel depending on the message level passed to mminit_dprintk(). What
    actually happens is that for MMINIT_WARNING and levels, only the loglevel
    is sent to printk() and not the message. This patch fixes the code to behave
    as intended.

    It can be folded safely into
    mm-add-a-basic-debugging-framework-for-memory-initialisation.patch without
    causing collisions later in the set.

    Signed-off-by: Mel Gorman <mel@csn.ul.ie>
    ---
    mm/internal.h | 4 ++--
    1 file changed, 2 insertions(+), 2 deletions(-)

    diff -rup -X /usr/src/patchset-0.6/bin//dontdiff linux-2.6.25-mm1-0010_mminit_debug_framework/mm/internal.h linux-2.6.25-mm1-0015_fix_mminit_dprink/mm/internal.h
    --- linux-2.6.25-mm1-0010_mminit_debug_framework/mm/internal.h 2008-04-30 09:47:55.000000000 +0100
    +++ linux-2.6.25-mm1-0015_fix_mminit_dprink/mm/internal.h 2008-04-30 11:33:41.000000000 +0100
    @@ -73,8 +73,8 @@ extern int mminit_loglevel;
    #define mminit_dprintk(level, prefix, fmt, arg...) \
    do { \
    if (level < mminit_loglevel) { \
    - printk(level <= MMINIT_WARNING ? KERN_WARNING : KERN_DEBUG \
    - "mminit:: " prefix " " fmt, ##arg); \
    + printk(level <= MMINIT_WARNING ? KERN_WARNING : KERN_DEBUG); \
    + printk(KERN_CONT "mminit::" prefix " " fmt, ##arg); \
    } \
    } while (0)



    \
     
     \ /
      Last update: 2008-04-30 13:33    [W:0.043 / U:171.248 seconds]
    ©2003-2017 Jasper Spaans. hosted at Digital OceanAdvertise on this site