Messages in this thread | | | From | Johannes Weiner <> | Subject | Re: [RFC 18/22] sh: Use generic show_mem() | Date | Thu, 03 Apr 2008 15:08:39 +0200 |
| |
Hi Paul,
Paul Mundt <lethal@linux-sh.org> writes:
> On Wed, Apr 02, 2008 at 10:40:24PM +0200, Johannes Weiner wrote: >> - printk(KERN_INFO "Total of %ld pages in page table cache\n", >> - quicklist_total_size()); >> -} >> - > > NACK. The quicklists are also absent from the generic implementation. > Doing things generically is nice and all, but please do not go around > removing all of the different implementations and consolidating on the > simplest point of commonality you could come up with. Either combine > everything in to a generic show_mem() that doesn't sacrifice > functionality, or only convert the platforms that are identical.
Sorry, I made it an RFC because I was not quite sure if the generic pfn walker is valid on all affected architectures. If it is okay, I will send a patch-set meant for application that does not miss any output.
Thanks,
Hannes
| |