Messages in this thread | | | Date | Tue, 29 Apr 2008 21:19:46 +0200 | From | Sam Ravnborg <> | Subject | Re: [PATCH 1/3] make access_process_vm work on device memory |
| |
On Tue, Apr 29, 2008 at 12:13:22PM -0700, Andrew Morton wrote: > On Tue, 29 Apr 2008 21:01:32 +0200 > Sam Ravnborg <sam@ravnborg.org> wrote: > > > > urgh. > > > > > > We have HAVE_ARCH* > > > We have __HAVE_ARCH* > > > We have ARCH_HAS* > > > We have __ARCH_HAS* > > > > > > what a mess. > > > > > > Probably the preferred (but still ugly) approach is to implement > > > CONFIG_ARCH_*. > > Only if it is a Kconfig symbol. > > > > We have recently started to use 'HAVE_*' for boolean symbols used > > to select a specific function for one architecture. > > See arch/Kconfig for a few samples. > > > > And Documentation/kbuild/kconfig-language.txt for usage hints. > > > > I think what you're telling us is to use CONFIG_HAVE_IOREMAP_PROT?
I think so. But I just stumbled upon this mail and have not even tried to follow what you discuss.
So yes - if it is a kconfig symbol. And if it is a bool. And if it has no dependencies, or we can create a helper with no dependencies - so yes.
Sam
| |