lkml.org 
[lkml]   [2008]   [Apr]   [29]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    Date
    From
    Subject[10/12] V4L: Fix VIDIOCGAP corruption in ivtv

    2.6.24-stable review patch. If anyone has any objections, please let us
    know.

    ------------------

    From: Alan Cox <alan@lxorguk.ukuu.org.uk>

    Frank Bennett reported that ivtv was causing skype to crash. With help
    from one of their developers he showed it was a kernel problem.
    VIDIOCGCAP copies a name into a fixed length buffer - ivtv uses names
    that are too long and does not truncate them so corrupts a few bytes of
    the app data area.

    Possibly the names also want trimming but for now this should fix the
    corruption case.

    Signed-off-by: Alan Cox <alan@redhat.com>
    Signed-off-by: Hans Verkuil <hverkuil@xs4all.nl>
    Signed-off-by: Mauro Carvalho Chehab <mchehab@infradead.org>
    Signed-off-by: Michael Krufky <mkrufky@linuxtv.org>
    (cherry picked from commit d2b213f7b76f187c4391079c7581d3a08b940133)
    Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>

    ---
    drivers/media/video/ivtv/ivtv-ioctl.c | 3 ++-
    1 file changed, 2 insertions(+), 1 deletion(-)

    --- a/drivers/media/video/ivtv/ivtv-ioctl.c
    +++ b/drivers/media/video/ivtv/ivtv-ioctl.c
    @@ -727,7 +727,8 @@ int ivtv_v4l2_ioctls(struct ivtv *itv, s

    memset(vcap, 0, sizeof(*vcap));
    strcpy(vcap->driver, IVTV_DRIVER_NAME); /* driver name */
    - strcpy(vcap->card, itv->card_name); /* card type */
    + strncpy(vcap->card, itv->card_name,
    + sizeof(vcap->card)-1); /* card type */
    strcpy(vcap->bus_info, pci_name(itv->dev)); /* bus info... */
    vcap->version = IVTV_DRIVER_VERSION; /* version */
    vcap->capabilities = itv->v4l2_cap; /* capabilities */
    --


    \
     
     \ /
      Last update: 2008-04-29 20:59    [W:0.027 / U:32.328 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site