lkml.org 
[lkml]   [2008]   [Apr]   [29]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: Issue with qla2xxx_probe_one
On Tue, 29 Apr 2008, Alan D. Brunelle wrote:

> I /think/ that there is an issue with this routine /if/ the firmware
> images are not loaded properly - on a 16-way ia64 box I am starting to
> see this with an up-stream kernel (Jens Axboe's origin/io-cpu-affinity
> branch). In any event, it looks to me that :
>
> if (qla2x00_initialize_adapter(ha)) {
> qla_printk(KERN_WARNING, ha,
> "Failed to initialize adapter\n");
>
> DEBUG2(printk("scsi(%ld): Failed to initialize adapter - "
> "Adapter flags %x.\n",
> ha->host_no, ha->device_flags));
>
> ret = -ENODEV;
> goto probe_failed;
> }
>
> skips around:
>
> ret = scsi_add_host(host, &pdev->dev);
>
> which is needed to properly initialize the freelist (via:
> scsi_setup_command_freelist).

Wasn't something like this posted recently to linux-scsi:

http://lkml.org/lkml/2008/4/27/333

this is sitting in scsi-misc-2.6.git:

[SCSI] bug fix for free list handling
http://git.kernel.org/?p=linux/kernel/git/jejb/scsi-misc-2.6.git;a=commitdiff;h=a79cbe1aa5dd695f0ee012ecde1ff88b1192e326

which I gather will be pushed soon...

> When qla2xxx_probe_one ends up calling scsi_host_put in this error path
> it eventually gets to scsi_destroy_command_freelist and we get the error
> below.


\
 
 \ /
  Last update: 2008-04-29 19:47    [W:0.055 / U:1.060 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site