lkml.org 
[lkml]   [2008]   [Apr]   [29]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    Date
    From
    Subject[18/37] S2io: Fix memory leak during free_tx_buffers
    2.6.25-stable review patch.  If anyone has any objections, please let us
    know.

    ------------------
    From: Sreenivasa Honnur <Sreenivasa.Honnur@neterion.com>
    commit b35b3b49fc6750806964048b31799c8782980ef9 upstream

    - Fix the memory leak during free_tx_buffers.

    Signed-off-by: Santosh Rastapur <santosh.rastapur@neterion.com>
    Signed-off-by: Ramkrishna Vepa <ram.vepa@neterion.com>
    Signed-off-by: Jeff Garzik <jgarzik@redhat.com>
    Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>

    ---
    drivers/net/s2io.c | 2 +-
    1 file changed, 1 insertion(+), 1 deletion(-)
    --- a/drivers/net/s2io.c
    +++ b/drivers/net/s2io.c
    @@ -2339,7 +2339,7 @@ static void free_tx_buffers(struct s2io_
    for (i = 0; i < config->tx_fifo_num; i++) {
    unsigned long flags;
    spin_lock_irqsave(&mac_control->fifos[i].tx_lock, flags);
    - for (j = 0; j < config->tx_cfg[i].fifo_len - 1; j++) {
    + for (j = 0; j < config->tx_cfg[i].fifo_len; j++) {
    txdp = (struct TxD *) \
    mac_control->fifos[i].list_info[j].list_virt_addr;
    skb = s2io_txdl_getskb(&mac_control->fifos[i], txdp, j);
    --


    \
     
     \ /
      Last update: 2008-04-29 19:31    [from the cache]
    ©2003-2014 Jasper Spaans. Advertise on this site