Messages in this thread | | | From | "Miller, Mike (OS Dev)" <> | Date | Tue, 29 Apr 2008 15:26:58 +0000 | Subject | RE: [PATCH 7/12] cciss: assign PDE->data before gluing PDE into /proc tree |
| |
> -----Original Message----- > From: den@sw.ru [mailto:den@sw.ru] On Behalf Of Denis V. Lunev > Sent: Tuesday, April 29, 2008 6:13 AM > To: akpm@linux-foundation.org > Cc: linux-kernel@vger.kernel.org; Denis V. Lunev; Alexey > Dobriyan; Eric W. Biederman; ISS StorageDev; Greg Kroah-Hartman > Subject: [PATCH 7/12] cciss: assign PDE->data before gluing > PDE into /proc tree > > Simply replace proc_create and further data assigned with > proc_create_data. > > Signed-off-by: Denis V. Lunev <den@openvz.org> > Cc: Alexey Dobriyan <adobriyan@openvz.org> > Cc: Eric W. Biederman <ebiederm@xmission.com> > Cc: <iss_storagedev@hp.com> > Cc: Greg Kroah-Hartman <gregkh@suse.de>
Acked-by: Mike Miller <mike.miller@hp.com>
> --- > drivers/block/cciss.c | 8 ++------ > 1 files changed, 2 insertions(+), 6 deletions(-) > > diff --git a/drivers/block/cciss.c b/drivers/block/cciss.c > index e539be5..e336b05 100644 > --- a/drivers/block/cciss.c > +++ b/drivers/block/cciss.c > @@ -428,13 +428,9 @@ static void __devinit cciss_procinit(int i) > proc_cciss = proc_mkdir("driver/cciss", NULL); > if (!proc_cciss) > return; > - pde = proc_create(hba[i]->devname, S_IWUSR | S_IRUSR > | S_IRGRP | > + pde = proc_create_data(hba[i]->devname, S_IWUSR | S_IRUSR | > + S_IRGRP | > S_IROTH, proc_cciss, > - &cciss_proc_fops); > - if (!pde) > - return; > - > - pde->data = hba[i]; > + &cciss_proc_fops, hba[i]); > } > #endif /* CONFIG_PROC_FS */ > > -- > 1.5.3.rc5 > >
| |