Messages in this thread | | | Date | Mon, 28 Apr 2008 10:16:35 +0200 | From | "Luca Tettamanti" <> | Subject | Re: [PATCH] Fix compile error with wifi & leds |
| |
On Mon, Apr 28, 2008 at 9:54 AM, Adrian Bunk <bunk@kernel.org> wrote: > On Mon, Apr 28, 2008 at 10:45:31AM +0300, Adrian Bunk wrote: > > Can you send the .config that gives this problem?
Just select IWL4965_LEDS without enabling LEDS_TRIGGERS.
> Scrap that, I already got the problem (and your patch looks right).
It works, yes - but I don't like it... NEW_LEDS enables the core code of the leds driver but also enables/disables the compilation of the whole driver/leds directory; *every* user of the led driver has to select whatever config option it wants (e.g. LEDS_TRIGGERS) _plus_ NEW_LEDS, otherwise led code won't be compiled. From a quick inspection RT2{4,5}00PCI_LEDS (driver/net/wireless/rt2x00) have the same problem, they select LEDS_CLASS without enabling NEW_LEDS -> unresolved symbols :| Maybe LEDS_* should also select NEW_LEDS?
Luca
| |