Messages in this thread | | | From | Bjorn Helgaas <> | Subject | Re: [patch 26/54] PNP: factor pnp_init_resource_table() and pnp_clean_resource_table() | Date | Mon, 28 Apr 2008 11:15:54 -0600 |
| |
On Saturday 26 April 2008 03:33:16 pm Rene Herman wrote: > On 25-04-08 20:38, Bjorn Helgaas wrote: > > > void pnp_init_resources(struct pnp_dev *dev) > > { > > - struct pnp_resource_table *table = &dev->res; > > + struct resource *res; > > int idx; > > > > for (idx = 0; idx < PNP_MAX_IRQ; idx++) { > > - table->irq_resource[idx].name = NULL; > > - table->irq_resource[idx].start = -1; > > - table->irq_resource[idx].end = -1; > > - table->irq_resource[idx].flags = > > - IORESOURCE_IRQ | IORESOURCE_AUTO | IORESOURCE_UNSET; > > + res = &dev->res.irq_resource[idx]; > > + res->flags = IORESOURCE_IRQ; > > ACK as commented earlier but pnp_clean_resource_table would seem to want the > same treatment of setting the type, at least to again guarantee current > behaviour:
We always initialize the type in pnp_init_resources(), and while we do fiddle with some of the other bits in the flags element, I can't see anyplace where we would clear the type.
But I did add code to set the type in pnp_clean_resource_table(), just in case. It could be hard to debug a problem there, and it's harmless to set it again.
Bjorn
| |