lkml.org 
[lkml]   [2008]   [Apr]   [28]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    From
    SubjectRe: [patch 21/54] PNP: add debug when assigning PNP resources
    Date
    On Saturday 26 April 2008 03:26:20 pm Rene Herman wrote:
    > On 25-04-08 20:38, Bjorn Helgaas wrote:
    > > +#else
    > > +void dbg_pnp_show_resources(struct pnp_dev *dev, char *desc)
    > > +{
    > > +}
    > > +#endif
    >
    > Not too important, but #ifdef could be inside body.

    Much nicer, thanks.

    I'll add your updates and acks and repost this series today.

    > > + dev_dbg(&dev->dev, " io %d already set to 0x%llx-0x%llx "
    > > + "flags 0x%x\n", idx, (unsigned long long) *start,
    > > + (unsigned long long) *end, (int) *flags);
    >
    > I wanted to ask/comment why you're casting the flags to int though. It's an
    > unsigned long, both in the resource and by type here. Ie, 0x%lx and no
    > casting? (I btw also like %#lx better then the explicit 0x, but that doesn't
    > really matter).

    Two more good ideas. The cast was just me not paying attention, and
    the "0x%x" habit is deeply ingrained. I'll change both.

    Bjorn



    \
     
     \ /
      Last update: 2008-04-28 17:29    [W:0.025 / U:58.552 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site