Messages in this thread | | | From | "Alexander van Heukelum" <> | Subject | Re: [PATCH] bitops: simplify generic bit finding functions | Date | Mon, 28 Apr 2008 16:58:43 +0200 |
| |
On Sun, 27 Apr 2008 13:26:34 -0700 (PDT), "Linus Torvalds" <torvalds@linux-foundation.org> said: > On Sun, 27 Apr 2008, Harvey Harrison wrote: > > > > No need for a sentinal if we explicitly catch the no bits/all bits set > > cases, make it clear they are special cases returning size/BITS_PER_LONG. > > These things need to be re-done anyway. David already complained that the > thing inlines to something much much too big. > > Let's just make it not be an inline at all.
Hello,
I think that's the wrong way to go about it. The problem that David Miller pointed out was that the small-bitmap optimization caused an inliningdisaster. Apparently, the generic version of __ffs is very big on sparc64. In my opinion the implementation of __ffs should be made out of line. If you move the wrapper of find_first_bit etc out of line, all possibilities of optimization will be destroyed. Better to remove them completely, then.
Greetings, Alexander
> Linus > -- > To unsubscribe from this list: send the line "unsubscribe linux-kernel" > in > the body of a message to majordomo@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html > Please read the FAQ at http://www.tux.org/lkml/ > > -- Alexander van Heukelum heukelum@fastmail.fm
-- http://www.fastmail.fm - Accessible with your email software or over the web
| |