Messages in this thread | | | Date | Mon, 28 Apr 2008 09:40:56 +1000 | From | David Chinner <> | Subject | Re: [PATCH] xfs: reduce stack usage in xfs_bmap_btalloc() |
| |
On Sat, Apr 26, 2008 at 04:51:02PM +0200, Denys Vlasenko wrote: > Hi David, > > This patch reduces xfs_bmap_btalloc() stack usage by 50 bytes > by moving part of its body into a helper function.
Can you please attach your patches inline, Denys (see Documentation/SubmittingPatches)?
> This results in some variables not taking stack space in > xfs_bmap_btalloc() anymore. > > The helper itself does not call anything stack-deep. > Stack-deep call to xfs_alloc_vextent() happen > in xfs_bmap_btalloc(), as before.
I have a set of patches that introduces new functionality into the allocator (dynamic allocation policies) that reduces xfs_bmap_btalloc() function by 36 bytes (just by chance, I didn't design it for this purpose). It breaks it down on functional boundaries like Christoph's patch. I'm going to revist that patch w.r.t both these patches and see what falls out the bottom...
Cheers,
Dave. -- Dave Chinner Principal Engineer SGI Australian Software Group
| |