[lkml]   [2008]   [Apr]   [25]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
Messages in this thread
    SubjectRe: [PATCH 1/2] pci/irq: restore mask_bits in msi shutdown -v3
    On Wednesday, April 23, 2008 2:56 pm Yinghai Lu wrote:
    > Yinghai found after using 2.6.25-rc3 later to kexec RHEL 5.1,
    > NIC can not be used.
    > bisected to

    Hi Yinghai, I've been thinking about these patches a bit... They seem like an
    important bug fix (making sure kexec'd kernels work), but I'm a bit worried
    that the kexec'd kernel can't handle potentially broken MSI/INTx setups.
    Shouldn't the kexec'd kernel be a bit more robust? I guess in this case
    you're kexec'ing an old kernel, so there's not much we can do, but it still
    makes me a little uneasy.

    I guess for this particular set it doesn't matter much, since we should be
    restoring things in pci_msi*_shutdown and pci_shutdown_device either way.
    Can you clean up the changelog a bit and maybe make it more concise? E.g. we
    probably don't need the whole commit message for the bisect, and we want to
    be clearer about what the failure mode is w/o the changes...


     \ /
      Last update: 2008-04-25 23:51    [W:0.019 / U:5.920 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site